Lalant commented on code in PR #7379:
URL: https://github.com/apache/ignite-3/pull/7379#discussion_r2697839600
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java:
##########
@@ -210,9 +210,17 @@ private void
processWriteCommand(CommandClosure<WriteCommand> clo) {
} else if (command instanceof SafeTimeSyncCommand) {
result = handleSafeTimeSyncCommand((SafeTimeSyncCommand)
command, commandIndex, commandTerm);
} else if (command instanceof PrimaryReplicaChangeCommand) {
+ PrimaryReplicaChangeCommand cmd =
(PrimaryReplicaChangeCommand) command;
+ LOG.info("Processing PrimaryReplicaChangeCommand
[groupId={}, commandIndex={}, commandTerm={}, "
+ + "leaseStartTime={}, primaryNodeId={},
primaryNodeName={}]",
+ partitionKey.toReplicationGroupId(), commandIndex,
commandTerm,
+ cmd.leaseStartTime(), cmd.primaryReplicaNodeId(),
cmd.primaryReplicaNodeName());
+
Review Comment:
Personally, I’d prefer to keep all logs at info level for better
traceability, but I understand that some trade-offs are necessary. This
particular log was useful for investigating the lease issue. However, under
normal circumstances, I agree it can be downgraded to debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
