Vladsz83 commented on code in PR #12620:
URL: https://github.com/apache/ignite/pull/12620#discussion_r2698644442
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryMetricsUpdateMessage.java:
##########
@@ -79,130 +83,136 @@ public TcpDiscoveryMetricsUpdateMessage(UUID
creatorNodeId) {
/**
* Sets metrics for particular node.
*
- * @param nodeId Node ID.
- * @param metrics Node metrics.
+ * @param srvrId Server ID.
+ * @param newMetrics New server metrics to add.
*/
- public void setMetrics(UUID nodeId, ClusterMetrics metrics) {
- assert nodeId != null;
- assert metrics != null;
- assert !this.metrics.containsKey(nodeId);
+ public void addServerMetrics(UUID srvrId, ClusterMetrics newMetrics) {
+ assert srvrId != null;
Review Comment:
We still can drop a node by the metrics. At least a client. Look for
'_Failing client node due to not receiving metrics updates_ '. It traverses a
map. If key not found, node is considered as failed. Unfortunatelly. I would
not touch this logic and what related to it. Instead, we might move these
metrics into Communication. And/or remove them at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
