shishkovilja commented on code in PR #12402:
URL: https://github.com/apache/ignite/pull/12402#discussion_r2705321149
##########
modules/core/src/test/java/org/apache/ignite/internal/managers/communication/IgniteIoCommunicationMessageSerializationTest.java:
##########
@@ -38,6 +39,9 @@ public class IgniteIoCommunicationMessageSerializationTest
extends AbstractMessa
if (msg instanceof NodeIdMessage)
FieldUtils.writeField(msg, "nodeId", UUID.randomUUID(), true);
+ if (msg instanceof PartitionUpdateCountersMessage)
Review Comment:
> I suggested removing the null check from the message and adding it to the
test. See [#12402
(comment)](https://github.com/apache/ignite/pull/12402#discussion_r2703703683)
But the final decision is up to you.
As I see we can safely send `null` for empty or `null` array. BUT, as I see
now, message will be in incorrect state if `data` is null.
So, you are right. Let's keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
