alex-plekhanov commented on code in PR #11770:
URL: https://github.com/apache/ignite/pull/11770#discussion_r2705870559
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/NestedLoopJoinNode.java:
##########
@@ -179,9 +179,6 @@ private static class LeftJoin<Row> extends
NestedLoopJoinNode<Row> {
/** Shows whether current left row was matched. */
private boolean matched;
- /** */
- private int rightIdx;
Review Comment:
`rewindInternal` should be fixed too
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/AbstractRightMaterializedJoinNode.java:
##########
@@ -134,7 +134,7 @@ private void pushLeft(Row row) throws Exception {
leftInBuf.add(row);
- join();
+ join0();
Review Comment:
Now we do `checkState` twice, on each row
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
