alex-plekhanov commented on code in PR #12600:
URL: https://github.com/apache/ignite/pull/12600#discussion_r2707907913
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/LogicalRelImplementor.java:
##########
@@ -942,4 +945,46 @@ private Node<Row> visit(RelNode rel) {
public <T extends Node<Row>> T go(IgniteRel rel) {
return (T)visit(rel);
}
+
+ /** */
+ private ScanStorageNode<Row> createStorageScan(
+ String storageName,
+ RelDataType outputRowType,
+ RelDataType inputRowType,
+ Iterable<Row> rowsIter,
+ @Nullable Predicate<Row> filter,
+ @Nullable Function<Row, Row> rowTransformer,
+ @Nullable ImmutableBitSet requiredColumns,
+ @Nullable ImmutableBitSet filterColumns
+ ) {
+ int fieldsCnt = outputRowType.getFieldCount();
+
+ if (filter == null || filterColumns == null ||
filterColumns.cardinality() == fieldsCnt
Review Comment:
It's a bug. `inputRowType` required here. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
