Vladsz83 commented on code in PR #12647:
URL: https://github.com/apache/ignite/pull/12647#discussion_r2713763674
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotOperation.java:
##########
@@ -18,28 +18,117 @@
package org.apache.ignite.internal.processors.cache.persistence.snapshot;
-import java.io.Serializable;
-import java.util.Set;
+import java.util.List;
+import
org.apache.ignite.internal.processors.cache.persistence.filename.SnapshotFileTree;
+import
org.apache.ignite.internal.util.distributed.DistributedProcess.DistributedProcessType;
+import org.apache.ignite.internal.util.tostring.GridToStringExclude;
+import org.apache.ignite.internal.util.typedef.internal.S;
/**
- * Initial snapshot operation interface.
+ * Current snapshot operation on local node.
*/
-public interface SnapshotOperation extends Serializable {
+public class SnapshotOperation {
+ /** */
+ private final SnapshotOperationRequest req;
Review Comment:
Should we rename to `SnapshotOperationStartRequest` since we have
`SnapshotOperationEndRequest` ?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotOperationRequest.java:
##########
@@ -18,13 +18,9 @@
package org.apache.ignite.internal.processors.cache.persistence.snapshot;
import java.util.Collection;
-import java.util.List;
import java.util.Set;
import java.util.UUID;
-import
org.apache.ignite.internal.processors.cache.persistence.filename.SnapshotFileTree;
import org.apache.ignite.internal.util.distributed.DistributedProcess;
-import
org.apache.ignite.internal.util.distributed.DistributedProcess.DistributedProcessType;
-import org.apache.ignite.internal.util.tostring.GridToStringExclude;
Review Comment:
Suggestion. Oce we introduce `SnapshotOperationEndRequest` with the
description mentioning of `{@link DistributedProcessType#END_SNAPSHOT} initiate
message`, let's change the comment below similary:
`request for {@link DistributedProcessType#START_SNAPSHOT} initiate message`
##########
modules/core/src/main/resources/META-INF/classnames.properties:
##########
@@ -1312,7 +1312,6 @@
org.apache.ignite.internal.processors.cache.persistence.snapshot.SnapshotHandler
org.apache.ignite.internal.processors.cache.persistence.snapshot.SnapshotHandlerResult
org.apache.ignite.internal.processors.cache.persistence.snapshot.SnapshotHandlerType
org.apache.ignite.internal.processors.cache.persistence.snapshot.SnapshotMetadata
-org.apache.ignite.internal.processors.cache.persistence.snapshot.SnapshotOperation
Review Comment:
Why removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
