xtern commented on code in PR #7471:
URL: https://github.com/apache/ignite-3/pull/7471#discussion_r2741071644
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/IgniteCorrelatedNestedLoopJoin.java:
##########
@@ -51,21 +53,26 @@
public class IgniteCorrelatedNestedLoopJoin extends AbstractIgniteJoin {
private static final String REL_TYPE_NAME = "CorrelatedNestedLoopJoin";
+ private final ImmutableBitSet correlationColumns;
Review Comment:
thanks
Added to explain.
```
CorrelatedNestedLoopJoin
...
correlates: [$cor0]
correlationColumns: [VAL]
```
Added test `testSubqueryCorrelationColumns` (to
`CorrelatedNestedLoopJoinPlannerTest`)
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/CorrelatedNestedLoopJoinNode.java:
##########
@@ -485,7 +491,14 @@ private Node<RowT> rightSource() {
private void prepareCorrelations() {
for (int i = 0; i < correlationIds.size(); i++) {
RowT row = i < leftInBuf.size() ? leftInBuf.get(i) :
first(leftInBuf);
- context().correlatedVariable(row, correlationIds.get(i).getId());
+ int corrId = correlationIds.get(i).getId();
Review Comment:
Added test `testCorrelatedVariables` (to
`CorrelatedNestedLoopJoinExecutionTest`).
Not sure if it meets your expectations, please take a look.
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/expressions/SqlExpressionFactoryAdapter.java:
##########
@@ -303,7 +303,7 @@ public RowFactoryFactory<RowT> rowFactoryFactory() {
}
@Override
- public @Nullable RowT correlatedVariable(int id) {
+ public @Nullable Object correlatedVariable(int corrId, int fieldIndex)
{
return null;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
