sk0x50 commented on code in PR #7488:
URL: https://github.com/apache/ignite-3/pull/7488#discussion_r2787049089
##########
modules/network/src/main/java/org/apache/ignite/internal/network/DefaultMessagingService.java:
##########
@@ -210,6 +225,8 @@ public CompletableFuture<Void> send(String
recipientConsistentId, ChannelType ch
InternalClusterNode recipient =
topologyService.getByConsistentId(recipientConsistentId);
if (recipient == null) {
+ metrics.incrementMessageRecipientNotFound();
Review Comment:
Well, in general, this behaviour a little contradicts the IEP:
> The MetricsSource.disable() method cleans up all resources if needed and
assigns null to the holder reference internally.
https://cwiki.apache.org/confluence/display/IGNITE/IEP-116%3A+Metrics#IEP116:Metrics-Disablemetrics
In my humble opinion, supporting disabled metrics is not very practical.
Anyway, it's up to you.
> This might even be desirable behaviour, since if the source is enabled at
a later time, we get to see a complete picture of all metric values without any
information loss.
If you think it's important and appropriate for these metrics, then I won't
object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
