shishkovilja commented on code in PR #12715:
URL: https://github.com/apache/ignite/pull/12715#discussion_r2793186618
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtAffinityAssignmentResponse.java:
##########
@@ -41,37 +38,39 @@
*/
public class GridDhtAffinityAssignmentResponse extends GridCacheGroupIdMessage
{
/** */
+ @Order(value = 4, method = "futureId")
private long futId;
/** Topology version. */
+ @Order(value = 5, method = "topologyVersion")
private AffinityTopologyVersion topVer;
/** */
- @GridDirectTransient
private List<List<UUID>> affAssignmentIds;
/** */
+ @Order(value = 6, method = "affinityAssignmentIdsBytes")
private byte[] affAssignmentIdsBytes;
/** */
- @GridDirectTransient
private List<List<UUID>> idealAffAssignment;
/** Affinity assignment bytes. */
+ @Order(value = 7, method = "idealAffinityAssignmentsBytes")
private byte[] idealAffAssignmentBytes;
/** */
- @GridDirectTransient
private GridDhtPartitionFullMap partMap;
/** */
+ @Order(value = 8, method = "partitionBytes")
private byte[] partBytes;
Review Comment:
Should be removed, see the above comment.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtAffinityAssignmentResponse.java:
##########
@@ -41,37 +38,39 @@
*/
public class GridDhtAffinityAssignmentResponse extends GridCacheGroupIdMessage
{
/** */
+ @Order(value = 4, method = "futureId")
private long futId;
/** Topology version. */
+ @Order(value = 5, method = "topologyVersion")
private AffinityTopologyVersion topVer;
/** */
- @GridDirectTransient
private List<List<UUID>> affAssignmentIds;
Review Comment:
Message framework does not support `List<List<...>>` collections, but we can
replace it by collection of specific messages, eg.
`List<AffinityAssignmentsList>` (`AffinityAssignmentsList` should encapsulate
`List<UUID>`).
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtAffinityAssignmentResponse.java:
##########
@@ -41,37 +38,39 @@
*/
public class GridDhtAffinityAssignmentResponse extends GridCacheGroupIdMessage
{
/** */
+ @Order(value = 4, method = "futureId")
private long futId;
/** Topology version. */
+ @Order(value = 5, method = "topologyVersion")
private AffinityTopologyVersion topVer;
/** */
- @GridDirectTransient
private List<List<UUID>> affAssignmentIds;
/** */
+ @Order(value = 6, method = "affinityAssignmentIdsBytes")
private byte[] affAssignmentIdsBytes;
Review Comment:
Should be removed, see the above comment.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtAffinityAssignmentResponse.java:
##########
@@ -41,37 +38,39 @@
*/
public class GridDhtAffinityAssignmentResponse extends GridCacheGroupIdMessage
{
/** */
+ @Order(value = 4, method = "futureId")
private long futId;
/** Topology version. */
+ @Order(value = 5, method = "topologyVersion")
private AffinityTopologyVersion topVer;
/** */
- @GridDirectTransient
private List<List<UUID>> affAssignmentIds;
/** */
+ @Order(value = 6, method = "affinityAssignmentIdsBytes")
private byte[] affAssignmentIdsBytes;
/** */
- @GridDirectTransient
private List<List<UUID>> idealAffAssignment;
Review Comment:
The same situatiion as with `affAssignmentIds`: let's use
`List<AffinityAssignmentsList>`.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtAffinityAssignmentResponse.java:
##########
@@ -41,37 +38,39 @@
*/
public class GridDhtAffinityAssignmentResponse extends GridCacheGroupIdMessage
{
/** */
+ @Order(value = 4, method = "futureId")
private long futId;
/** Topology version. */
+ @Order(value = 5, method = "topologyVersion")
private AffinityTopologyVersion topVer;
/** */
- @GridDirectTransient
private List<List<UUID>> affAssignmentIds;
/** */
+ @Order(value = 6, method = "affinityAssignmentIdsBytes")
private byte[] affAssignmentIdsBytes;
/** */
- @GridDirectTransient
private List<List<UUID>> idealAffAssignment;
/** Affinity assignment bytes. */
+ @Order(value = 7, method = "idealAffinityAssignmentsBytes")
private byte[] idealAffAssignmentBytes;
Review Comment:
Should be removed, see the above comment.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtAffinityAssignmentResponse.java:
##########
@@ -41,37 +38,39 @@
*/
public class GridDhtAffinityAssignmentResponse extends GridCacheGroupIdMessage
{
/** */
+ @Order(value = 4, method = "futureId")
private long futId;
/** Topology version. */
+ @Order(value = 5, method = "topologyVersion")
private AffinityTopologyVersion topVer;
/** */
- @GridDirectTransient
private List<List<UUID>> affAssignmentIds;
/** */
+ @Order(value = 6, method = "affinityAssignmentIdsBytes")
private byte[] affAssignmentIdsBytes;
/** */
- @GridDirectTransient
private List<List<UUID>> idealAffAssignment;
/** Affinity assignment bytes. */
+ @Order(value = 7, method = "idealAffinityAssignmentsBytes")
private byte[] idealAffAssignmentBytes;
/** */
- @GridDirectTransient
private GridDhtPartitionFullMap partMap;
Review Comment:
There are no guarantees for `GridDhtPartitionFullMap` to support RU. But we
need to provide it. Because it is not external object we need to transform it
to `Message` or use another `Message` as DTO of `GridDhtPartitionFullMap`.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtAffinityAssignmentResponse.java:
##########
@@ -41,37 +38,39 @@
*/
public class GridDhtAffinityAssignmentResponse extends GridCacheGroupIdMessage
{
/** */
+ @Order(value = 4, method = "futureId")
private long futId;
/** Topology version. */
+ @Order(value = 5, method = "topologyVersion")
private AffinityTopologyVersion topVer;
/** */
- @GridDirectTransient
private List<List<UUID>> affAssignmentIds;
/** */
+ @Order(value = 6, method = "affinityAssignmentIdsBytes")
private byte[] affAssignmentIdsBytes;
/** */
- @GridDirectTransient
private List<List<UUID>> idealAffAssignment;
/** Affinity assignment bytes. */
+ @Order(value = 7, method = "idealAffinityAssignmentsBytes")
private byte[] idealAffAssignmentBytes;
/** */
- @GridDirectTransient
private GridDhtPartitionFullMap partMap;
/** */
+ @Order(value = 8, method = "partitionBytes")
private byte[] partBytes;
/** Indicates that getting required affinity assignments has been failed.
*/
- @GridDirectTransient
private IgniteCheckedException affAssignmentErr;
/** Serialized error. */
+ @Order(value = 9, method = "affinityAssignmentsErrorBytes")
private byte[] affAssignmentErrBytes;
Review Comment:
Should be removed, see the above comment.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtAffinityAssignmentResponse.java:
##########
@@ -41,37 +38,39 @@
*/
public class GridDhtAffinityAssignmentResponse extends GridCacheGroupIdMessage
{
/** */
+ @Order(value = 4, method = "futureId")
private long futId;
/** Topology version. */
+ @Order(value = 5, method = "topologyVersion")
private AffinityTopologyVersion topVer;
/** */
- @GridDirectTransient
private List<List<UUID>> affAssignmentIds;
/** */
+ @Order(value = 6, method = "affinityAssignmentIdsBytes")
private byte[] affAssignmentIdsBytes;
/** */
- @GridDirectTransient
private List<List<UUID>> idealAffAssignment;
/** Affinity assignment bytes. */
+ @Order(value = 7, method = "idealAffinityAssignmentsBytes")
private byte[] idealAffAssignmentBytes;
/** */
- @GridDirectTransient
private GridDhtPartitionFullMap partMap;
/** */
+ @Order(value = 8, method = "partitionBytes")
private byte[] partBytes;
/** Indicates that getting required affinity assignments has been failed.
*/
- @GridDirectTransient
private IgniteCheckedException affAssignmentErr;
Review Comment:
Let's use `ErrorMessage`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
