AMashenkov commented on code in PR #7564: URL: https://github.com/apache/ignite-3/pull/7564#discussion_r2798634932
########## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/DataNodesAwarePartitionCountProvider.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.catalog; + +import static java.lang.Math.max; + +import org.apache.ignite.internal.system.CpuInformationProvider; + +/** + * Primary to use partition count provider. It calculates the number of partitions using the formula: + * dataNodesCount * max(cores, 8) * scaleFactor / replicas. Data nodes count is the estimated number of data nodes for the given + * distribution zone. It is assumed that each node has the same number of CPU cores. Also, there is doubling multiplier to allow the cluster + * scale up. + */ +public class DataNodesAwarePartitionCountProvider implements PartitionCountProvider { Review Comment: Catalog relies that PartitionCountProvider will be implemented and provided from outside. You introduces 3 more entities DataNodesAwarePartitionCountProvider, CpuInformationProvider, EstimatedDataNodeCountProvider. DataNodesAwarePartitionCountProvider is an implementation, but it can't be used directly in Catalog, because of dependencies. Other 2 interfaces have no implementations and have nothing with the Catalog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
