rpuch opened a new pull request, #7584:
URL: https://github.com/apache/ignite-3/pull/7584

   https://issues.apache.org/jira/browse/IGNITE-27460
   
   * Introduce full commands validation wrt schema compatibility
    - do the validation in Raft state machine
    - on failed validation, return the result to Replica listener
    - in Replica listener, handle the failure by retrying the request
   * Introduce a mechanism to make sure Raft state machine always has enough 
metadata (schemas) while validating full commands; this is to prevent blocking 
Raft state machine threads due to waiting for schema completeness
    - reject ActionRequests bearing commands whose validation would require to 
wait on schema sync
    - introduce SafeTimeValidator for this end
    - reject log replication if the acceptor does not have sufficient schema 
information yet
   
   Thank you for submitting the pull request.
   
   To streamline the review process of the patch and ensure better code quality
   we ask both an author and a reviewer to verify the following:
   
   ### The Review Checklist
   - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. 
Also make sure to complete the following:  
   \- There is a single JIRA ticket related to the pull request.  
   \- The web-link to the pull request is attached to the JIRA ticket.  
   \- The JIRA ticket has the Patch Available state.  
   \- The description of the JIRA ticket explains WHAT was made, WHY and HOW.  
   \- The pull request title is treated as the final commit message. The 
following pattern must be used: IGNITE-XXXX Change summary where XXXX - number 
of JIRA issue.
   - [ ] **Design:** new code conforms with the design principles of the 
components it is added to.
   - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size 
must be reasonable.
   - [ ] **Code quality:** code is clean and readable, necessary developer 
documentation is added if needed.
   - [ ] **Tests code quality:** test set covers positive/negative scenarios, 
happy/edge cases. Tests are effective in terms of execution time and resources.
   
   ### Notes
   - [Apache Ignite Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to