sk0x50 commented on code in PR #7488:
URL: https://github.com/apache/ignite-3/pull/7488#discussion_r2814234736
##########
modules/network/src/main/java/org/apache/ignite/internal/network/DefaultMessagingService.java:
##########
@@ -210,6 +225,8 @@ public CompletableFuture<Void> send(String
recipientConsistentId, ChannelType ch
InternalClusterNode recipient =
topologyService.getByConsistentId(recipientConsistentId);
if (recipient == null) {
+ metrics.incrementMessageRecipientNotFound();
Review Comment:
In general, the main idea of a metric source assumes that it provides a
holder and defines all metrics.
It means you operate on the source rather than changing a metric directly.
This design allows us to control a list of metrics that the source provides
(for example, `MessagingServiceMetricSource` looks like a generic container
that can be used for any metric you want, even though it is not related to the
messaging service), and easily release resources by disabling the source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
