shishkovilja commented on code in PR #12735:
URL: https://github.com/apache/ignite/pull/12735#discussion_r2816279496
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentInfoBean.java:
##########
@@ -42,24 +38,38 @@ public class GridDeploymentInfoBean implements Message,
GridDeploymentInfo, Exte
/** */
private static final long serialVersionUID = 0L;
- /** */
+ /**
+ *
Review Comment:
Purpose of changes?
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentInfoBean.java:
##########
@@ -42,24 +38,38 @@ public class GridDeploymentInfoBean implements Message,
GridDeploymentInfo, Exte
/** */
private static final long serialVersionUID = 0L;
- /** */
+ /**
+ *
+ */
+ @Order(value = 0, method = "classLoaderId")
private IgniteUuid clsLdrId;
- /** */
+ /**
+ *
+ */
+ @Order(value = 1, method = "deployMode")
private DeploymentMode depMode;
- /** */
- private String userVer;
-
- /** */
+ /**
+ *
Review Comment:
Purpose of changes?
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentInfoBean.java:
##########
@@ -68,9 +78,9 @@ public GridDeploymentInfoBean() {
}
/**
- * @param clsLdrId Class loader ID.
- * @param userVer User version.
- * @param depMode Deployment mode.
+ * @param clsLdrId Class loader ID.
Review Comment:
Purpose of changes?
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentInfoBean.java:
##########
@@ -68,9 +78,9 @@ public GridDeploymentInfoBean() {
}
/**
- * @param clsLdrId Class loader ID.
- * @param userVer User version.
- * @param depMode Deployment mode.
+ * @param clsLdrId Class loader ID.
+ * @param userVer User version.
Review Comment:
Purpose of changes?
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentInfoBean.java:
##########
@@ -42,24 +38,38 @@ public class GridDeploymentInfoBean implements Message,
GridDeploymentInfo, Exte
/** */
private static final long serialVersionUID = 0L;
- /** */
+ /**
+ *
+ */
+ @Order(value = 0, method = "classLoaderId")
private IgniteUuid clsLdrId;
- /** */
+ /**
+ *
+ */
+ @Order(value = 1, method = "deployMode")
private DeploymentMode depMode;
- /** */
- private String userVer;
-
- /** */
+ /**
+ *
+ */
+ @Order(value = 2, method = "localDeploymentOwner")
@Deprecated // Left for backward compatibility only.
private boolean locDepOwner;
- /** Node class loader participant map. */
+ /**
+ * Node class loader participant map.
+ */
@GridToStringInclude
- @GridDirectMap(keyType = UUID.class, valueType = IgniteUuid.class)
+ @Order(3)
private Map<UUID, IgniteUuid> participants;
+ /**
+ *
Review Comment:
Purpose of changes?
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentInfoBean.java:
##########
@@ -68,9 +78,9 @@ public GridDeploymentInfoBean() {
}
/**
- * @param clsLdrId Class loader ID.
- * @param userVer User version.
- * @param depMode Deployment mode.
+ * @param clsLdrId Class loader ID.
+ * @param userVer User version.
+ * @param depMode Deployment mode.
Review Comment:
Purpose of changes?
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentInfoBean.java:
##########
@@ -42,24 +38,38 @@ public class GridDeploymentInfoBean implements Message,
GridDeploymentInfo, Exte
/** */
private static final long serialVersionUID = 0L;
- /** */
+ /**
+ *
+ */
+ @Order(value = 0, method = "classLoaderId")
private IgniteUuid clsLdrId;
- /** */
+ /**
+ *
+ */
+ @Order(value = 1, method = "deployMode")
private DeploymentMode depMode;
- /** */
- private String userVer;
-
- /** */
+ /**
+ *
+ */
+ @Order(value = 2, method = "localDeploymentOwner")
@Deprecated // Left for backward compatibility only.
private boolean locDepOwner;
- /** Node class loader participant map. */
+ /**
+ * Node class loader participant map.
Review Comment:
Purpose of changes?
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentInfoBean.java:
##########
@@ -42,24 +38,38 @@ public class GridDeploymentInfoBean implements Message,
GridDeploymentInfo, Exte
/** */
private static final long serialVersionUID = 0L;
- /** */
+ /**
+ *
+ */
+ @Order(value = 0, method = "classLoaderId")
private IgniteUuid clsLdrId;
- /** */
+ /**
+ *
Review Comment:
Purpose of changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
