timoninmaxim commented on code in PR #12783:
URL: https://github.com/apache/ignite/pull/12783#discussion_r2844589034


##########
modules/core/src/main/java/org/apache/ignite/client/ClientCacheConfiguration.java:
##########
@@ -793,6 +797,27 @@ public ClientCacheConfiguration 
setExpiryPolicy(ExpiryPolicy expiryPlc) {
         return this;
     }
 
+    /**
+     * Gets partitions count.
+     *
+     * @return Partitions count.
+     */
+    public int getPartitions() {
+        return partitions;
+    }
+
+    /**
+     * Sets partitions count.
+     *
+     * @param partitions Partitions count.
+     * @return {@code this} for chaining.
+     */
+    public ClientCacheConfiguration setPartitions(int partitions) {

Review Comment:
   I don't like the idea of separating partitions from affinity function on 
thin clients. I think we should discuss API would allow full configuring 
affinity function on thin clients.
   
   ClientCacheConfiguration#setAffinityFunction(Class<?> affinityFunction, 
Object... args). 



##########
modules/core/src/main/java/org/apache/ignite/client/ClientCacheConfiguration.java:
##########
@@ -793,6 +797,27 @@ public ClientCacheConfiguration 
setExpiryPolicy(ExpiryPolicy expiryPlc) {
         return this;
     }
 
+    /**
+     * Gets partitions count.
+     *
+     * @return Partitions count.
+     */
+    public int getPartitions() {
+        return partitions;
+    }
+
+    /**
+     * Sets partitions count.
+     *
+     * @param partitions Partitions count.
+     * @return {@code this} for chaining.
+     */
+    public ClientCacheConfiguration setPartitions(int partitions) {

Review Comment:
   I don't like the idea of separating partitions from affinity function on 
thin clients. I think we should discuss API would allow full configuring 
affinity function on thin clients. Smth like:
   
   ClientCacheConfiguration#setAffinityFunction(Class<?> affinityFunction, 
Object... args). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to