ibessonov commented on code in PR #7610:
URL: https://github.com/apache/ignite-3/pull/7610#discussion_r2847230133
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManager.java:
##########
@@ -96,6 +96,12 @@ class SegmentFileManager implements ManuallyCloseable {
private static final int ROLLOVER_WAIT_TIMEOUT_MS = 30_000;
+ /**
+ * Maximum number of times we try to read data from a segment file
returned based the index before giving up and throwing an
+ * exception. See {@link #readFromOtherSegmentFiles} for more information.
+ */
+ private static final int MAX_NUM_INDEX_FILE_READ_RETRIES = 5;
Review Comment:
I think it's an overkill, I wouldn't mind a `while (true)` to be honest, but
if you think that it's safer to have a limitation the you're free to leave it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
