oleg-vlsk commented on code in PR #12760:
URL: https://github.com/apache/ignite/pull/12760#discussion_r2850143086
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentLocalStore.java:
##########
@@ -263,6 +267,20 @@ class GridDeploymentLocalStore extends
GridDeploymentStoreAdapter {
return dep;
}
+ else {
+ ClassLoader ldr =
Thread.currentThread().getContextClassLoader();
+
+ if (ldr == null)
+ ldr = U.resolveClassLoader(ctx.config());
Review Comment:
Moved classloader initialization outside the for loop, but kept
`dep.classLoader() == ldr` as a separate if-block to be able to log correct
trace messages. As I understand, if we add the `|| dep.classLoader() == ldr`
condition to the initial if-block, the trace message will contain either null
as classloader id or incorrect classloader id. As well as it won’t be obvious
from such message that the local app classloader was used in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
