dant3 commented on code in PR #7657:
URL: https://github.com/apache/ignite-3/pull/7657#discussion_r2852911598
##########
modules/compute/src/main/java/org/apache/ignite/internal/compute/task/TaskExecutionInternal.java:
##########
@@ -184,13 +184,13 @@ public TaskExecutionInternal(
private void captureReduceExecution(QueueExecution<R> reduceExecution,
Throwable throwable) {
if (throwable != null) {
- captureReduceSubmitFailure(throwable);
+ captureReduceSubmitFailure();
} else {
handleReduceResult(reduceExecution);
}
}
- private void captureReduceSubmitFailure(Throwable throwable) {
+ private void captureReduceSubmitFailure() {
Review Comment:
yea, it should probably be logged, I guess. We have logEvent there, but we
still loose the original error and stacktrace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
