shishkovilja commented on code in PR #12821:
URL: https://github.com/apache/ignite/pull/12821#discussion_r2873249545


##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ClientImpl.java:
##########
@@ -2241,7 +2239,7 @@ private void 
processNodeAddedMessage(TcpDiscoveryNodeAddedMessage msg) {
 
                         nodeAdded = true;
 
-                        if (msg.topologyHistory() != null)
+                        if (!F.isEmpty(msg.topologyHistory()))

Review Comment:
   Does behavior changed now? Why we need this change?



##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -5086,7 +5078,9 @@ else if (spiState == CONNECTING)
                             joiningNodesDiscoDataList = new ArrayList<>();
 
                             topHist.clear();
-                            topHist.putAll(msg.topologyHistory());
+
+                            if (!F.isEmpty(msg.topologyHistory()))

Review Comment:
   Does behavior changed now? Why we need this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to