sergey-chugunov-1985 commented on code in PR #12825:
URL: https://github.com/apache/ignite/pull/12825#discussion_r2876856493
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxStateImpl.java:
##########
@@ -293,6 +297,16 @@ public class IgniteTxStateImpl extends
IgniteTxLocalStateAdapter {
/** {@inheritDoc} */
@Override public boolean storeWriteThrough(GridCacheSharedContext sctx) {
+ if (storeWriteThrough != null)
Review Comment:
Do we actually need to optimize this part? Method's call tree makes me
thinking that the method is called once on each node during execution of a
specific part of tx's handling procedure.
If this is true we don't need this additional logic.
##########
modules/core/src/test/java/org/apache/ignite/cache/store/CacheStoreWithIgniteTxFailureTest.java:
##########
@@ -194,6 +192,8 @@ public void testSystemExceptionAfterCacheStoreCommit()
throws Exception {
.filter(ignite ->
((IgniteEx)ignite).context().clientNode())
.count() == 1);
}
+ else
+ waitForTopology(2);
Review Comment:
Can we add some additional checks here to examine dead and alive nodes? Like
it is done in `then` branch with check for client node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
