ivanzlenko commented on code in PR #7796:
URL: https://github.com/apache/ignite-3/pull/7796#discussion_r2944271464
##########
modules/network/src/main/java/org/apache/ignite/internal/network/scalecube/ScaleCubeDirectMarshallerTransport.java:
##########
@@ -137,20 +133,14 @@ public Mono<Void> stop() {
});
}
- /** {@inheritDoc} */
@Override
public boolean isStopped() {
return onStop.isDisposed();
}
- /** {@inheritDoc} */
@Override
- public Mono<Void> send(Address address, Message message) {
- var addr = new NetworkAddress(address.host(), address.port());
-
- return Mono.fromFuture(() -> {
- return messagingService.send(addr, SCALE_CUBE_CHANNEL_TYPE,
fromMessage(message));
- });
+ public Mono<Void> send(String address, Message message) {
+ return Mono.fromFuture(() ->
messagingService.send(NetworkAddress.from(address), SCALE_CUBE_CHANNEL_TYPE,
fromMessage(message)));
Review Comment:
Can't we just store address as a NetworkAddress here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
