NSAmelchev commented on code in PR #12901:
URL: https://github.com/apache/ignite/pull/12901#discussion_r2946146110


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/marshaller/MarshallerMappingItem.java:
##########
@@ -26,7 +27,10 @@
  *  Used to exchange mapping information on new mapping added or missing 
mapping requested flows.
  *  See {@link GridMarshallerMappingProcessor} javadoc for more information.
  */
-public final class MarshallerMappingItem implements Message {
+public final class MarshallerMappingItem implements Message, Serializable {

Review Comment:
   Correct, but now many places require Serializable, for example 
TcpDiscoveryNodeAddedMessage#msgs, TcpDiscoveryClientReconnectMessage#msgs. In 
these and some other java SerDer (called via U.marshal(jdkMarshaller)) requires 
Serializable.
   
   I suggest removing Serializable when it becomes possible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to