shishkovilja commented on code in PR #12891:
URL: https://github.com/apache/ignite/pull/12891#discussion_r2953254111
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java:
##########
@@ -2054,9 +2047,6 @@ else if (async)
ackC.apply(null);
}
else {
- if (topicOrd < 0)
Review Comment:
This condition also should be taken into account in #prepareMarshal.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java:
##########
Review Comment:
It seems that `if` block can be removed, and code of `topic` initialization
should be completely placed intoto `#finishUnmarshall`.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java:
##########
Review Comment:
It seems that `if` block can be removed, and code of `topic` initialization
should be completely placed intoto `#finishUnmarshall`.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java:
##########
@@ -1980,9 +1976,6 @@ private IgniteInternalFuture<Channel> openChannel(
);
try {
- if (topicOrd < 0)
Review Comment:
This condition also should be taken into account in `#prepareMarshal`.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/eventstorage/GridEventStorageMessage.java:
##########
@@ -219,31 +217,33 @@ public void prepareMarshal(Marshaller marsh) throws
IgniteCheckedException {
evtsBytes = U.marshal(marsh, evts);
}
- /**
- * @param marsh Marshaller.
- * @param ldr Class loader.
- * @param filterClsLdr Class loader for filter.
- */
- public void finishUnmarshal(Marshaller marsh, ClassLoader ldr, ClassLoader
filterClsLdr) throws IgniteCheckedException {
+ /** {@inheritDoc} */
+ @Override public void finishUnmarshal(Marshaller marsh, ClassLoader ldr)
throws IgniteCheckedException {
if (resTopicBytes != null && resTopic == null) {
resTopic = U.unmarshal(marsh, resTopicBytes, ldr);
resTopicBytes = null;
}
- if (filterBytes != null && filter == null && filterClsLdr != null) {
Review Comment:
`filterClsLdr != null` we are missing this condition now. But can it be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
