shishkovilja commented on code in PR #12780:
URL: https://github.com/apache/ignite/pull/12780#discussion_r2958599881
##########
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySelfTest.java:
##########
@@ -149,6 +153,31 @@ public TcpDiscoverySelfTest() throws Exception {
super(false);
}
+ /**
Review Comment:
Why do we need this change in this PR?
##########
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySelfTest.java:
##########
@@ -231,8 +260,16 @@ else if (igniteInstanceName.contains("MulticastIpFinder"))
{
// Loopback multicast discovery is not working on Mac OS
// (possibly due to
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7122846).
- if (U.isMacOs())
- spi.setLocalAddress(F.first(U.allLocalIps()));
+ if (U.isMacOs()) {
Review Comment:
Why o we need this change in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
