Copilot commented on code in PR #7881: URL: https://github.com/apache/ignite-3/pull/7881#discussion_r2995753773
########## modules/platforms/cpp/ignite/common/detail/hash_utils_test.cpp: ########## @@ -18,13 +18,13 @@ #include <ignite/common/detail/string_extensions.h> #include <algorithm> -#define _USE_MATH_DEFINES -#include <cmath> #include <iterator> #include <limits> #include <gtest/gtest.h> +#define TEST_PI 3.14159265358979323846 Review Comment: Using a macro for a numeric constant is avoidable here and can unnecessarily pollute the preprocessor namespace. Prefer a typed constant (e.g., `constexpr double kTestPi = 3.14159265358979323846;`) in an unnamed namespace or as `static constexpr` in this test TU to preserve type-safety and avoid macro side effects. ```suggestion static constexpr double TEST_PI = 3.14159265358979323846; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
