ptupitsyn commented on code in PR #12947:
URL: https://github.com/apache/ignite/pull/12947#discussion_r2995682988
##########
modules/core/src/main/java/org/apache/ignite/cache/query/SqlFieldsQuery.java:
##########
@@ -322,43 +311,6 @@ public boolean isReplicatedOnly() {
return replicatedOnly;
}
- /**
- * Sets lazy query execution flag.
- * <p>
- * If {@code lazy=false} Ignite will attempt to fetch the whole query
result set to memory and send it to the client. For small
- * and medium result sets this provides optimal performance and minimize
duration of internal database locks, thus
- * increasing concurrency.
- * <p>
- * If result set is too big to fit in available memory this could lead to
excessive GC pauses and even
- * {@link OutOfMemoryError}. Use this flag as a hint for Ignite to fetch
result set lazily, thus minimizing memory
- * consumption at the cost of moderate performance hit.
- * <p>
- * Defaults to {@code true}, meaning that the only first page of result
set is fetched to memory.
- *
- * @param lazy Lazy query execution flag.
- * @return {@code this} For chaining.
- * @deprecated Use {@link #setPageSize(int)} instead.
- */
- @Deprecated
Review Comment:
Public API, was not marked as `@Deprecated(forRemoval = true)` => should not
be removed.
Let's mark `forRemoval` for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
