chesnokoff commented on code in PR #12933:
URL: https://github.com/apache/ignite/pull/12933#discussion_r2999256706
##########
modules/core/src/test/java/org/apache/ignite/testframework/junits/multijvm/IgniteNodeRunner.java:
##########
@@ -67,11 +67,50 @@ public static void main(String[] args) throws Exception {
X.println("Starting Ignite Node... Args=" + Arrays.toString(args));
+ startParentPipeWatcher();
+
Review Comment:
Initially, my idea was to introduce the following structure:
```
IgniteNodeRunner {
void run() {
startParentPipeWatcher();
doRun();
}
void doRun() {
<custom logic>
}
}
IgniteCompatibilityNodeRunner {
@Override void doRun() {
<custom logic>
}
}
```
This approach was implemented in the first commit of this PR.
However, the problem is that `IgniteNodeRunner` is located in the core
module, and for compatibility tests we load its older versions (see
`IgniteCompatibilityAbstractTest#getDependencies`, `getExcluded`).
As a result, `IgniteCompatibilityNodeRunner` cannot override methods of
older versions of `IgniteNodeRunner`.
I believe that, for now, it’s better to just copy-paste
`IgniteCompatibilityNodeRunner#startParentPipeWatcher` into `IgniteNodeRunner`,
since it currently has only one inheritor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
