chesnokoff commented on code in PR #12954: URL: https://github.com/apache/ignite/pull/12954#discussion_r3004547730
########## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/store/GridCacheStoreManagerAdapter.java: ########## Review Comment: There is one implementation detail to consider. In the write-behind scenario, `loadAll` may not actually call the underlying cache store, but instead return entries from the `writeCache` (see `GridCacheWriteBehindStore#loadAll`, specifically the `remaining` variable). As a result, we currently log logical calls to the cache store rather than physical ones. This approach is justified by the following: - It is still possible to estimate whether a call was real based on its duration - `GridCacheWriteBehindStore` does not have straightforward access to the Ignite context required to invoke performance statistics operations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
