Cyrill commented on code in PR #7813:
URL: https://github.com/apache/ignite-3/pull/7813#discussion_r3027445886
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java:
##########
@@ -504,7 +505,7 @@ private MetaStorageServiceImpl
createMetaStorageService(RaftGroupService raftSer
);
}
- private CompletableFuture<? extends RaftGroupService> startVotingNode(
+ private CompletableFuture<PhysicalTopologyAwareRaftGroupService>
startVotingNode(
Review Comment:
Any benefits of doing that in private methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
