chesnokoff commented on code in PR #12974:
URL: https://github.com/apache/ignite/pull/12974#discussion_r3043351273
##########
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TestTcpDiscoverySpi.java:
##########
@@ -100,4 +110,32 @@ public void discoveryHook(DiscoveryHook discoHook) {
this.discoHook = discoHook;
}
+
+ /**
+ * Sets test discovery messages factory provider. Note that {@link
DiscoveryHook} must be set before SPI start.
+ * Otherwise, this method call will take no effect.
+ *
+ * @param msgFactoryProvider Discovery messages factory provider.
+ */
+ public void messageFactory(MessageFactoryProvider msgFactoryProvider) {
Review Comment:
The doc looks like a copy-paste from `discoveryHook(...)`. The method sets a
`MessageFactoryProvider`, not a `DiscoveryHook`, so the second sentence should
probably say that the message factory provider must be set before SPI start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
