Phillippko commented on code in PR #7969:
URL: https://github.com/apache/ignite-3/pull/7969#discussion_r3077978804
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/SegmentLogStorageManager.java:
##########
@@ -63,17 +72,13 @@ public SegmentLogStorageManager(
}
@Override
- public LogStorage createLogStorage(String groupId, RaftOptions
raftOptions) {
- return new SegstoreLogStorage(convertGroupId(groupId), fileManager);
+ public LogStorage createLogStorage(String raftNodeStorageId, RaftOptions
raftOptions) {
+ return new SegstoreLogStorage(convertNodeId(raftNodeStorageId),
fileManager);
}
@Override
- public void destroyLogStorage(String groupId) {
- try {
- fileManager.reset(convertGroupId(groupId), 1);
- } catch (IOException e) {
- throw new LogStorageException("Failed to destroy log storage for
group " + groupId, e);
- }
+ public void destroyLogStorage(String raftNodeStorageId) {
+ // TODO IGNITE-28527 Implement.
Review Comment:
Current implementation is incorrect, and fix is not trivial, so will be done
separately
Segstore is still WIP, so it is OK. This PR is to allow testing and finding
bugs in segstore, not making it production ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
