zstan commented on code in PR #13019:
URL: https://github.com/apache/ignite/pull/13019#discussion_r3078018900
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/IgniteSqlValidator.java:
##########
@@ -327,6 +328,14 @@ else if (call.getKind() == SqlKind.CAST) {
super.validateAggregateParams(aggCall, filter, null, orderList, scope);
}
+ /** {@inheritDoc} */
+ @Override protected void validateJoin(SqlJoin join, SqlValidatorScope
scope) {
+ if (join.getJoinType() == JoinType.ASOF || join.getJoinType() ==
JoinType.LEFT_ASOF)
+ throw newValidationError(join,
IgniteResource.INSTANCE.unsupportedJoinType(join.getJoinType().name()));
Review Comment:
nit-picking - i just prefer this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
