ptupitsyn commented on code in PR #7854:
URL: https://github.com/apache/ignite-3/pull/7854#discussion_r3079709352
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItDataConsistencyTest.java:
##########
@@ -217,6 +218,12 @@ private Runnable createWriter(int workerId) {
} catch (TransactionException e) {
// Don't need to rollback manually if got IgniteException.
fails.increment();
+ } catch (ClientRetriableTransactionException e) {
Review Comment:
`ClientRetriableTransactionException` is internal and must be never observed
by the user.
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/core/exception/handler/SqlExceptionHandler.java:
##########
@@ -63,14 +63,28 @@ private static ErrorUiComponent
connectionErrUiComponent(IgniteException e) {
return fromIgniteException("Client error", e);
}
- if (e.getCause() instanceof IgniteClientConnectionException) {
- IgniteClientConnectionException cause =
(IgniteClientConnectionException) e.getCause();
+ if (e instanceof IgniteClientConnectionException) {
+ IgniteClientConnectionException cause =
(IgniteClientConnectionException) e;
InvalidCredentialsException invalidCredentialsException =
findCause(cause, InvalidCredentialsException.class);
if (invalidCredentialsException != null) {
+ var msg = invalidCredentialsException.getMessage();
+
+ String details;
+ var headerIdx = msg.indexOf('\n');
Review Comment:
Can `msg` be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
