isapego commented on code in PR #7966:
URL: https://github.com/apache/ignite-3/pull/7966#discussion_r3080264807
##########
modules/platforms/cpp/ignite/common/uuid_test.cpp:
##########
@@ -64,3 +64,54 @@ TEST(uuid, stream) {
EXPECT_EQ(uuidString, uuidString2);
}
+
+TEST(uuid, incorrect_string_representation) {
+ auto uuidText = "foo";
+
+ auto resOpt = ignite::uuid::from_string(uuidText);
+
+ EXPECT_FALSE(resOpt.has_value());
+}
+
+class uuid_string_presentation_fixture: public
::testing::TestWithParam<std::tuple<std::string, ignite::uuid>> {};
+
+TEST_P(uuid_string_presentation_fixture, from_string) {
+ auto [uuidText, uuid] = GetParam();
+
+ auto resOpt = ignite::uuid::from_string(uuidText);
+
+ EXPECT_TRUE(resOpt.has_value());
+
+ EXPECT_EQ(uuid.get_most_significant_bits(),
resOpt->get_most_significant_bits());
+ EXPECT_EQ(uuid.get_least_significant_bits(),
resOpt->get_least_significant_bits());
+}
+
+// We check that two representation are consistent both ways.
+TEST_P(uuid_string_presentation_fixture, to_string) {
+ auto [uuidText, uuid] = GetParam();
+
+
+ std::stringstream ss;
+ ss << uuid;
+
+ EXPECT_EQ(uuidText, ss.str());
+}
+
+// Values has taken randomly from java program, as this implementation should
have same behaviour as java.lang.UUID for compatibility reasons.
+INSTANTIATE_TEST_SUITE_P(
+ various_uuids,
+ uuid_string_presentation_fixture,
+ ::testing::Values(
+ std::tuple{"4b62e46a-d380-460f-94ea-9b4320752634",
ignite::uuid{5432155248028304911LL, -7716184298936261068LL}},
+ std::tuple{"cabf7114-7763-4ad5-b312-5ffadcbf48c8",
ignite::uuid{-3837224024780092715, -5543262660289673016}},
+ std::tuple{"8ee62c79-5636-44b9-adc4-c9b4272a2ba6",
ignite::uuid{-8149777576031271751, -5925389434124358746}},
+ std::tuple{"3e69a946-fc2a-4da1-9938-d1f082dd36ce",
ignite::uuid{4497311825249586593, -7405938756292888882}},
+ std::tuple{"7cc9f130-821b-4580-bfda-955072540643",
ignite::uuid{8991983321665455488, -4622217894794361277}},
+ std::tuple{"1f86b0b1-dfab-4108-8b7e-8b3e4177ceb0",
ignite::uuid{2271697340063236360, -8395119555869421904}},
+ std::tuple{"88cc69d9-d191-482d-b295-aa458cf99167",
ignite::uuid{-8589374005057599443, -5578365347733859993}},
+ std::tuple{"a8b6298c-126e-4c4d-a521-de3989a31492",
ignite::uuid{-6289794147994940339, -6547708044516322158}},
+ std::tuple{"03b210a8-5a6a-4cae-b4fc-f30df9f1eebd",
ignite::uuid{266293643225746606, -5405178211397931331}},
+ std::tuple{"f145e277-bb58-4f89-adfa-3166a975b71b",
ignite::uuid{-1061193133303771255, -5910357243970865381}},
+ std::tuple{"dc8b5857-067f-486e-aa5b-52cbdb26dd9c",
ignite::uuid{-2554851232808220562, -6171247828872536676}}
Review Comment:
Why do we pass uuid values here? Let's get them using `from_string`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
