zstan commented on code in PR #13011:
URL: https://github.com/apache/ignite/pull/13011#discussion_r3111005464


##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/AbstractPlannerTest.java:
##########
@@ -619,6 +626,49 @@ protected <T extends RelNode> Predicate<RelNode> 
input(Predicate<T> predicate) {
         return input(0, predicate);
     }
 
+    /** Low level conditions analyzer. */
+    private static boolean validateIdxConditions(IgniteIndexScan node, SqlKind 
opKind, String... strConditions) {
+        /** */
+        Set<String> conditions = new HashSet<>();
+
+        /** */
+        RexShuttle shuttle = new RexShuttle() {
+            boolean firstCall = true;
+
+            @Override public RexNode visitCall(RexCall call) {
+                if (firstCall) {

Review Comment:
   @alex-plekhanov with using Shuttle i believe code a bit readable that flat 
one, but if you insist i will fix it.
   Other part is refactored. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to