sergey-chugunov-1985 commented on code in PR #13072:
URL: https://github.com/apache/ignite/pull/13072#discussion_r3152577563
##########
modules/compatibility/src/test/java/org/apache/ignite/compatibility/spi/discovery/TcpDiscoveryDifferentClusterVersionsTest.java:
##########
@@ -35,7 +35,7 @@
@RunWith(Parameterized.class)
public class TcpDiscoveryDifferentClusterVersionsTest extends
IgniteCompatibilityAbstractTest {
/** */
- private static final String INCOMPATIBLE_NODE_MSG = "is this an
incompatible Ignite node?";
+ private static final String INCOMPATIBLE_NODE_MSG = "possible incompatible
Ignite node";
Review Comment:
```suggestion
private static final String INCOMPATIBLE_NODE_MSG = "possible reasons:
incompatible Ignite node";
```
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -6639,16 +6687,16 @@ private class SocketReader extends IgniteSpiThread {
if (!Arrays.equals(buf, U.IGNITE_HEADER)) {
if (log.isDebugEnabled())
- log.debug("Unknown connection detected (is some
other software connecting to " +
- "this Ignite port, or is this an incompatible
Ignite node?" +
- (!spi.isSslEnabled() ? " missed SSL
configuration?" : "" ) +
+ log.debug("Unknown connection detected (possible
incompatible Ignite node, " +
Review Comment:
```suggestion
log.debug("Unknown connection detected (possible
reasons: an incompatible Ignite node or " +
```
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -6639,16 +6687,16 @@ private class SocketReader extends IgniteSpiThread {
if (!Arrays.equals(buf, U.IGNITE_HEADER)) {
if (log.isDebugEnabled())
- log.debug("Unknown connection detected (is some
other software connecting to " +
- "this Ignite port, or is this an incompatible
Ignite node?" +
- (!spi.isSslEnabled() ? " missed SSL
configuration?" : "" ) +
+ log.debug("Unknown connection detected (possible
incompatible Ignite node, " +
+ "other software connecting to this Ignite
port" +
+ (!spi.isSslEnabled() ? ", or missing SSL
configuration on remote node" : "") +
") [rmtAddr=" + rmtAddr +
", locAddr=" + sock.getLocalSocketAddress() +
", rcvdHdr=" + U.byteArray2HexString(buf) +
']');
- LT.warn(log, "Unknown connection detected (is some
other software connecting to " +
- "this Ignite port, or is this an incompatible
Ignite node?" +
- (!spi.isSslEnabled() ? " missing SSL configuration
on remote node?" : "" ) +
+ LT.warn(log, "Unknown connection detected (possible
incompatible Ignite node, " +
Review Comment:
```suggestion
LT.warn(log, "Unknown connection detected (possible
reasons: an incompatible Ignite node or " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
