alex-plekhanov commented on code in PR #12096: URL: https://github.com/apache/ignite/pull/12096#discussion_r3201432110
########## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rule/logical/ProjectWindowConstantsRule.java: ########## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.query.calcite.rule.logical; + +import java.util.ArrayList; +import java.util.List; +import com.google.common.collect.ImmutableList; +import org.apache.calcite.plan.RelOptRuleCall; +import org.apache.calcite.plan.RelRule; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Window; +import org.apache.calcite.rel.logical.LogicalWindow; +import org.apache.calcite.rel.rules.TransformationRule; +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rel.type.RelDataTypeFactory; +import org.apache.calcite.rel.type.RelDataTypeField; +import org.apache.calcite.rex.RexBuilder; +import org.apache.calcite.rex.RexInputRef; +import org.apache.calcite.rex.RexLiteral; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.rex.RexWindowBound; +import org.apache.calcite.rex.RexWindowBounds; +import org.apache.calcite.tools.RelBuilder; +import org.immutables.value.Value; + +/** + * A rule to split window rel with constants to: + * - project with constants + * - window without constants + * - project removing constants + */ [email protected] +public class ProjectWindowConstantsRule extends RelRule<ProjectWindowConstantsRule.Config> implements TransformationRule { Review Comment: As far as I understand now each calculation of each aggregate call will apply project, which will create the new row and copy input row to this row. In this case it's even more resource consuming than ProjectWindowConstantsRule. Maybe it's better to revert to ProjectWindowConstantsRule. In my opinion right way to implement this is to provide some list of precompiled functions (columns projections `List<Function<Row, T>>`) to `AbstractWindowFunction` (and `AbstractAccumulator`) and implement `get` method in these classes like: ``` (T)projects.get(arguments().get(idx)).apply(row) ``` instead of: ``` (T)hnd.get(arguments().get(idx), row) ``` In this case no additional rows will be created and only required column modifications will be applied. But let's do it later, by another ticket, this ticket is already too complex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
