animovscw commented on code in PR #12982:
URL: https://github.com/apache/ignite/pull/12982#discussion_r3223566102
##########
modules/core/src/test/java/org/apache/ignite/testframework/junits/multijvm/JavaVersionCommand.java:
##########
@@ -56,13 +55,16 @@ int majorVersion(String javaHome) throws IOException,
InterruptedException {
/**
* Reads whole stream content and returns it as a string. UTF-8 is used to
convert from bytes to string.
*
- * @param inputStream Stream to read.
+ * @param inputStream Stream to read.
* @return Stream content as a string.
* @throws IOException If something goes wrong.
*/
private String readStream(InputStream inputStream) throws IOException {
ByteArrayOutputStream baos = new ByteArrayOutputStream();
- IOUtils.copy(inputStream, baos);
+ byte[] buf = new byte[4096];
Review Comment:
Before this PR, Surefire 2.x was used for `modules/core` (inherited from
parent). In Surefire 2.x, `useSystemClassLoader=true` was the default, which
caused test-scoped dependencies to be available in forked processes. This PR
upgrades Surefire to **3.5.4** (via the new `maven.surefire.plugin.version`
property in `parent/pom.xml`). In Surefire 3.x, `IsolatedClassLoader` enforces
stricter classpath isolation — test-scoped jars are no longer propagated to
child JVM processes. Since `commons-io` is declared as `<scope>test</scope>` in
`modules/core/pom.xml`, it becomes unavailable in the forked JVM launched by
`IgniteProcessProxy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
