Vladsz83 commented on code in PR #12729:
URL: https://github.com/apache/ignite/pull/12729#discussion_r3241227641
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -3802,27 +3864,39 @@ else if (e instanceof SocketTimeoutException ||
if (!sent) {
if (sndState == null &&
spi.getEffectiveConnectionRecoveryTimeout() > 0)
- sndState = new CrossRingMessageSendState();
- else if (sndState != null && sndState.checkTimeout()) {
- segmentLocalNodeOnSendFail(failedNodes);
-
+ sndState = createConnectionRecoveryState(newNext);
+ else if (sndState != null &&
checkConnectionRecoveryFailed(sndState, failedNodes))
return; // Nothing to do here.
- }
- boolean failedNextNode = sndState == null ||
sndState.markNextNodeFailed();
+ // The next node might be reset as result of the parallel
remote DC ping process.
+ boolean failedNextNode = next != null && (sndState == null
|| sndState.markNextNodeFailed());
if (failedNextNode && !failedNodes.contains(next)) {
failedNodes.add(next);
+ TcpDiscoveryNode next0 = next;
+
+ if (allRemoteDCsTraversed(sndState, failedNodes,
next)) {
+ if (log.isInfoEnabled()) {
+ log.info("During the connection recovery, all
the remote DCs have been traversed. " +
Review Comment:
Fixed partly. Let's rely on the phrase "During connection recovery" widely
used before with the parallel DCs ping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
