shishkovilja commented on code in PR #13129:
URL: https://github.com/apache/ignite/pull/13129#discussion_r3246718974
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/TransactionsHashRecord.java:
##########
@@ -17,26 +17,36 @@
package org.apache.ignite.internal.processors.cache.verify;
+import java.io.Serializable;
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.internal.MarshallableMessage;
import org.apache.ignite.internal.Order;
-import org.apache.ignite.internal.dto.IgniteDataTransferObject;
import org.apache.ignite.internal.util.tostring.GridToStringInclude;
import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.marshaller.Marshaller;
/** Represents committed transactions hash for a pair of nodes. */
-public class TransactionsHashRecord extends IgniteDataTransferObject {
+public class TransactionsHashRecord implements MarshallableMessage,
Serializable {
/** */
private static final long serialVersionUID = 0L;
/** Consistent ID of local node that participated in the transaction. This
node produces this record. */
- @Order(0)
@GridToStringInclude
Object locConsistentId;
+ /** Bytes of {@link #locConsistentId}. */
+ @Order(0)
+ byte[] locConsistentIdBytes;
Review Comment:
```suggestion
transient byte[] locConsistentIdBytes;
```
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/TransactionsHashRecord.java:
##########
@@ -17,26 +17,36 @@
package org.apache.ignite.internal.processors.cache.verify;
+import java.io.Serializable;
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.internal.MarshallableMessage;
import org.apache.ignite.internal.Order;
-import org.apache.ignite.internal.dto.IgniteDataTransferObject;
import org.apache.ignite.internal.util.tostring.GridToStringInclude;
import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.marshaller.Marshaller;
/** Represents committed transactions hash for a pair of nodes. */
-public class TransactionsHashRecord extends IgniteDataTransferObject {
+public class TransactionsHashRecord implements MarshallableMessage,
Serializable {
/** */
private static final long serialVersionUID = 0L;
/** Consistent ID of local node that participated in the transaction. This
node produces this record. */
- @Order(0)
@GridToStringInclude
Object locConsistentId;
+ /** Bytes of {@link #locConsistentId}. */
+ @Order(0)
+ byte[] locConsistentIdBytes;
+
/** Consistent ID of remote node that participated in the transactions. */
- @Order(1)
@GridToStringInclude
Object rmtConsistentId;
+ /** Bytes of {@link #rmtConsistentId}. */
+ @Order(1)
+ byte[] rmtConsistentIdBytes;
Review Comment:
```suggestion
transient byte[] rmtConsistentIdBytes;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
