shishkovilja commented on issue #12316:
URL: https://github.com/apache/ignite/issues/12316#issuecomment-4475927406

   @jpsla94 ,
   
   "sonatype-2021-4292" looks false positive:
   
   > The readFrom() method in the ClientMessage class prematurely allocates a 
buffer before validating the size in the handshake's header and fails to 
release the reserved space when the header is invalid
   
   Above description is wrong. This problem was fixed in 2.13 [1]. In fact, 
size is checked, also we check the type of header. [2, 3]
   
   
   > Advisory Deviation Notice: The Sonatype security research team discovered 
that the read() method in the GridNioServerBuffer class, also has the 
vulnerable portion of code in it and was not taken into account in the fix.
   
   `GridNioServerBuffer` is used only in tests and examples. This class has no 
effect on the `ignite-core` module.
   
   ----
   
   Regarding sonatype-2022-5219, I'll check that later. But it looks like it 
also can't be used if cluster access is restricted.
   
   ----
   
   **Links:**
   1. https://issues.apache.org/jira/browse/IGNITE-15921
   2. 
https://github.com/apache/ignite/commit/85bb788bc6ab21668124fe07bee3d984752bc2c5#diff-c309c609b1d06f48b2ba18e3ed3f676150074f3597d72dfd7f3b248aaa082d3aR157
   3. 
https://github.com/apache/ignite/commit/85bb788bc6ab21668124fe07bee3d984752bc2c5#diff-c309c609b1d06f48b2ba18e3ed3f676150074f3597d72dfd7f3b248aaa082d3aR185
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to