maksaska commented on code in PR #12913:
URL: https://github.com/apache/ignite/pull/12913#discussion_r3259118561
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotHandlerTest.java:
##########
@@ -61,6 +61,9 @@ public class IgniteClusterSnapshotHandlerTest extends
IgniteClusterSnapshotResto
/** Custom snapshot handlers. */
private final List<SnapshotHandler<?>> handlers = new ArrayList<>();
+ /** Timeout in milliseconds to await for snapshot operation being
completed. */
+ protected static final long TIMEOUT = 60_000;
Review Comment:
Could you clarify the scope of this PR? The ticket description mentions
covering only Disk 4 tests, but this PR modifies
`IgniteClusterSnapshotHandlerTest`, which belongs to the Disk 5 suite.
- If we are including Disk 5: Please update the ticket description to avoid
confusion. Also, can we update the timeouts for `IgniteSnapshotMXBeanTest`
while we are at it?
- If Disk 5 is out of scope: I suggest reverting the changes to
`IgniteClusterSnapshotHandlerTest` to keep this PR focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
