chesnokoff commented on code in PR #13217:
URL: https://github.com/apache/ignite/pull/13217#discussion_r3386498068
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/RollingUpgradeProcessor.java:
##########
@@ -247,22 +237,13 @@ public void disable() throws IgniteCheckedException {
if (rollUpVers == null)
return;
- IgnitePair<IgniteProductVersion> minMaxVerPair =
ring.minMaxNodeVersions();
+ IgnitePair<IgniteProductVersion> minMaxVerPair =
resolveMinMaxNodeVersions();
Review Comment:
Probably we should move `resolveMinMaxNodeVersions` under the lock.
Otherwise, in theory, a joining node can be added to the discovery ring after
`resolveMinMaxNodeVersions` takes its snapshot but before we check
`lastJoiningNode`. If the corresponding discovery event clears
`lastJoiningNode` in that window, `disable` may use outdated version snapshot
and miss the joining node.
The probability looks low, but keeping the ring snapshot and lastJoiningNode
check under the same lock makes the invariant explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
