NSAmelchev commented on code in PR #13229:
URL: https://github.com/apache/ignite/pull/13229#discussion_r3394283441
##########
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/BinaryUtils.java:
##########
@@ -607,7 +607,7 @@ public static byte typeByClass(Class<?> cls) {
if (type != null)
return type;
- if (CommonUtils.isEnum(cls))
+ if (CommonUtils.isEnum(cls) || cls == Enum.class)
Review Comment:
`Enum.class` is not an enum (isEnum() == false) but is used as a binary
field type hint. Adding this to a common method for all components looks
questionable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
