Copilot commented on code in PR #13201:
URL: https://github.com/apache/ignite/pull/13201#discussion_r3394534698
##########
docs/_docs/includes/prereqs.adoc:
##########
@@ -14,7 +14,7 @@
// limitations under the License.
[width="100%",cols="1,3"]
|===
-|JDK |Oracle JDK 11 or 17 Open JDK 11 or 17, IBM JDK 11 or 17
+|JDK |Oracle JDK 17 Open JDK 17, IBM JDK 17
|OS |Linux (any flavor), Mac OSX (10.6 and up), Windows (XP and up),
Review Comment:
This table cell is missing a comma after "Oracle JDK 17", making the
prerequisites list hard to read (it currently reads as a single phrase).
##########
deliveries/docker/apache-ignite/run.sh:
##########
@@ -75,17 +75,33 @@ fi
#
# Add Java extra option
#
-if [ "${version}" -ge 11 ] ; then
+if [ "${version}" -ge 17 ] ; then
JVM_OPTS="\
- --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED \
- --add-exports=java.base/sun.nio.ch=ALL-UNNAMED \
- --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED \
- --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED \
-
--add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED \
- --add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED \
--add-opens=java.base/jdk.internal.access=ALL-UNNAMED \
+ --add-opens=java.base/jdk.internal.misc=ALL-UNNAMED \
+ --add-opens=java.base/sun.nio.ch=ALL-UNNAMED \
+ --add-opens=java.base/sun.util.calendar=ALL-UNNAMED \
+ --add-opens=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED \
+ --add-opens=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED \
+
--add-opens=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED \
+ --add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED \
+ --add-opens=java.base/java.io=ALL-UNNAMED \
+ --add-opens=java.base/java.nio=ALL-UNNAMED \
+ --add-opens=java.base/java.net=ALL-UNNAMED \
+ --add-opens=java.base/java.util=ALL-UNNAMED \
+ --add-opens=java.base/java.util.concurrent=ALL-UNNAMED \
+ --add-opens=java.base/java.util.concurrent.locks=ALL-UNNAMED \
+ --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED \
+ --add-opens=java.base/java.lang=ALL-UNNAMED \
+ --add-opens=java.base/java.lang.invoke=ALL-UNNAMED \
+ --add-opens=java.base/java.math=ALL-UNNAMED \
+ --add-opens=java.sql/java.sql=ALL-UNNAMED \
+ --add-opens=java.base/java.lang.reflect=ALL-UNNAMED \
+ --add-opens=java.base/java.time=ALL-UNNAMED \
+ --add-opens=java.base/java.text=ALL-UNNAMED \
--add-opens=java.logging/java.util.logging=ALL-UNNAMED \
- --illegal-access=permit \
+ --add-opens=java.management/sun.management=ALL-UNNAMED \
+ --add-opens java.desktop/java.awt.font=ALL-UNNAMED \
${JVM_OPTS}"
Review Comment:
All other --add-opens entries in this block use the "--add-opens=..." form;
this one uses a space instead, which is inconsistent and easy to copy/paste
incorrectly. Consider using the same "=" form everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
