Copilot commented on code in PR #13241:
URL: https://github.com/apache/ignite/pull/13241#discussion_r3414019961
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheOperationContext.java:
##########
@@ -64,6 +64,9 @@ public class CacheOperationContext implements Serializable {
/** Application attributes. */
private final Map<String, String> appAttrs;
+ /** Handle binary in interceptor operation flag . */
+ private final boolean handleBinaryInInterceptor;
Review Comment:
Minor Javadoc typo: extra space before the period in "flag .".
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheQueueAdapter.java:
##########
@@ -442,7 +442,8 @@ protected GridCacheQueueAdapter(String queueName,
GridCacheQueueHeader hdr, Grid
null,
false,
null,
- null)
+ null,
+ false)
Review Comment:
`withKeepBinary()` now only sets `keepBinary` in `CacheOperationContext`,
but interceptor-related logic was moved to the new `handleBinaryInInterceptor`
flag. As a result, calling `IgniteQueue.withKeepBinary()` will no longer
guarantee that `CacheInterceptor` sees binary values (and the early return can
skip enabling the new flag entirely). To preserve the historical behavior of
keep-binary projections, set `handleBinaryInInterceptor` alongside `keepBinary`
and only early-return when both flags are already enabled.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheOperationContext.java:
##########
@@ -87,6 +91,7 @@ public CacheOperationContext() {
* @param dataCenterId Data center id.
* @param readRepairStrategy Read-repair strategy.
* @param appAttrs Application attributes.
+ * @param handleBinaryInInterceptor Handle binary in interceptor operation
flag.
Review Comment:
This constructor Javadoc is out of sync with the signature: it documents
`dataCenterId` and `readRepairStrategy`, but omits `noRetries` and `recovery`,
which makes it harder to use correctly and can cause Javadoc generation
warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
