zstan commented on code in PR #13242:
URL: https://github.com/apache/ignite/pull/13242#discussion_r3442248862
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheOperationContext.java:
##########
@@ -108,38 +100,26 @@ public CacheOperationContext(
this.recovery = recovery;
this.readRepairStrategy = readRepairStrategy;
this.appAttrs = appAttrs;
+ this.handleBinaryInInterceptor = handleBinaryInInterceptor;
}
/**
- * @return Keep binary flag.
+ * Helper.
*/
- public boolean isKeepBinary() {
- return keepBinary;
+ public static CacheOperationContext instance() {
+ return INSTANCE;
}
/**
- * @return {@code True} if data center id is set otherwise {@code false}.
+ * @return keepBinary flag.
*/
- public boolean hasDataCenterId() {
- return dataCenterId != null;
+ public boolean isKeepBinary() {
+ return keepBinary;
}
- /**
- * See {@link IgniteInternalCache#keepBinary()}.
- *
- * @return New instance of CacheOperationContext with keep binary flag.
- */
- public CacheOperationContext keepBinary() {
- return new CacheOperationContext(
- skipStore,
- skipReadThrough,
- true,
- expiryPlc,
- noRetries,
- dataCenterId,
- recovery,
- readRepairStrategy,
- appAttrs);
+ /** Context with keepBinary flag. */
+ public CacheOperationContext withKeepBinary() {
+ return builder(this).keepBinary(true).build();
Review Comment:
done except expiration for same behavior as in
GridCacheAdapter#withExpiryPolicy, really don\`t know why equality is not
checked there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
