oleg-zinovev commented on code in PR #12096:
URL: https://github.com/apache/ignite/pull/12096#discussion_r3442286101
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/WindowNode.java:
##########
@@ -115,11 +112,10 @@ else if (prevRow != null && partCmp != null &&
partCmp.compare(prevRow, row) !=
prevRow = row;
- if (waiting == 0 && requested > 0) {
- waiting = IN_BUFFER_SIZE;
-
- context().execute(() -> source().request(IN_BUFFER_SIZE),
this::onError);
- }
+ if (waiting == 0 && outBuf.isEmpty())
+ source().request(waiting = IN_BUFFER_SIZE);
Review Comment:
@alex-plekhanov
Sry, I was inattentive.
I can’t wait to replace the WindowNode implementation with the new one.
It will be rolled back in next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
