petrov-mg commented on code in PR #13243:
URL: https://github.com/apache/ignite/pull/13243#discussion_r3452432513
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ClientImpl.java:
##########
@@ -2001,7 +2005,11 @@ else if (discoMsg instanceof
TcpDiscoveryCheckFailedMessage)
}
}
-
processDiscoveryMessage((TcpDiscoveryAbstractMessage)msg);
+ TcpDiscoveryAbstractMessage msg0 =
(TcpDiscoveryAbstractMessage)msg;
+
+ try (Scope ignored =
DistributedOperationContextManager.instance().restoreDistributedAttributes(msg0.opCtxMsg))
{
+ processDiscoveryMessage(msg0);
Review Comment:
It looks like we need to wrap not just the `processDiscoveryMessage` call,
but the entire processing of the message from the moment it is polled from the
queue.
##########
modules/core/src/main/java/org/apache/ignite/internal/DistributedOperationContextMessage.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal;
+
+import java.util.List;
+import org.apache.ignite.internal.thread.context.OperationContext;
+import org.apache.ignite.plugin.extensions.communication.Message;
+
+/** Transport for {@link OperationContext} distibuted attributes. */
+public class DistributedOperationContextAttributesMessage implements Message {
+ /** Values of operation context attributes. */
+ @Order(0)
+ public List<Message> vals;
Review Comment:
> extra GC load
This doesn't seem to be the case unless the created list goes outside the
scope of the method. Even if this is not, short-lived objects are extremely
optimized in modern JVMs.
But keeping tons of messages with unused arrays in discovery and
communication queues seems to be a more realistic problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
