Vladsz83 commented on code in PR #13243:
URL: https://github.com/apache/ignite/pull/13243#discussion_r3458119350
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ClientImpl.java:
##########
@@ -1757,276 +1761,290 @@ private MessageWorker(IgniteLogger log) {
blockingSectionEnd();
}
- if (msg instanceof JoinTimeout) {
- int joinCnt0 = ((JoinTimeout)msg).joinCnt;
-
- if (joinCnt == joinCnt0) {
- if (state == STARTING) {
- joinError(new IgniteSpiException("Join process
timed out, did not receive response for " +
- "join request (consider increasing
'joinTimeout' configuration property) " +
- "[joinTimeout=" + spi.joinTimeout + ",
sock=" + currSock + ']'));
-
+ if (msg instanceof TcpDiscoveryAbstractMessage msg0 &&
msg0.opCtxMsg != null) {
Review Comment:
We've already moved message processing in a dedicated methods in same manner
at other places. Message is a Object here, not even a Message. I need to check
its type first. An `if` is required. That is why I introduce a method or did
the processing in the part of code before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
