zstan commented on code in PR #13269:
URL: https://github.com/apache/ignite/pull/13269#discussion_r3474605926
##########
examples/src/main/java/org/apache/ignite/examples/misc/springbean/SpringBeanExample.java:
##########
@@ -83,7 +83,7 @@ public static void main(String[] args) throws Exception {
}
finally {
// Stop local cluster node.
- ctx.destroy();
+ ctx.close();
Review Comment:
try with resources?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java:
##########
@@ -1017,6 +1017,11 @@ private void startHttpProtocol() throws
IgniteCheckedException {
log.debug("Failed to initialize HTTP REST protocol (consider
adding ignite-rest-http " +
"module to classpath).");
}
+ catch (LinkageError e) {
+ U.warn(log, "Failed to initialize HTTP REST protocol because a
required dependency is missing " +
+ "from classpath (make sure the ignite-rest-http module
libraries, e.g. jakarta.servlet-api, " +
Review Comment:
plz change this desc
##########
modules/calcite/pom.xml:
##########
@@ -69,6 +69,12 @@
<groupId>org.apache.calcite</groupId>
<artifactId>calcite-core</artifactId>
<version>${calcite.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>jakarta.transaction</groupId>
+ <artifactId>jakarta.transaction-api</artifactId>
Review Comment:
may be we can eclude org.apache.commons:commons-dbcp2 ?
##########
modules/spring/src/main/java/org/apache/ignite/internal/processors/resource/GridResourceSpringBeanInjector.java:
##########
@@ -111,15 +111,15 @@ private Object getBeanByResourceAnnotation(SpringResource
annotation) throws Ign
String beanName = annotation.resourceName();
Class<?> beanCls = annotation.resourceClass();
- boolean oneParamSet = !StringUtils.isEmpty(beanName) ^ beanCls !=
SpringResource.DEFAULT.class;
+ boolean oneParamSet = !ObjectUtils.isEmpty(beanName) ^ beanCls !=
SpringResource.DEFAULT.class;
Review Comment:
may be change for F.isEmpty() ?
##########
modules/clients/src/test/resources/jetty/router-jetty.xml:
##########
@@ -61,17 +61,5 @@
</Arg>
</Call>
- <Set name="handler">
- <New id="Handlers"
class="org.eclipse.jetty.server.handler.HandlerCollection">
- <Set name="handlers">
- <Array type="org.eclipse.jetty.server.Handler">
- <Item>
- <New id="Contexts"
class="org.eclipse.jetty.server.handler.ContextHandlerCollection"/>
Review Comment:
just check it once more
##########
modules/web/ignite-websphere-test/src/main/java/org/apache/ignite/webtest/TestJtaTxServlet.java:
##########
@@ -56,7 +56,7 @@ public class TestJtaTxServlet extends HttpServlet {
final IgniteCache<Integer, String> cache = ignite.cache("tx");
- TransactionManager tmMgr =
TransactionManagerFactory.getTransactionManager();
+ UserTransaction tmMgr = (UserTransaction)new
InitialContext().lookup("java:comp/UserTransaction");
Review Comment:
may be we can obtain context from HttpServlet ?
##########
modules/extdata/uri/src/main/java/org/apache/ignite/spi/deployment/uri/tasks/GarHelloWorldTask.java:
##########
@@ -43,7 +43,8 @@ public class GarHelloWorldTask extends
ComputeTaskSplitAdapter<String, String> {
/** {@inheritDoc} */
@Override public Collection<? extends ComputeJob> split(int gridSize,
String arg) throws IgniteException {
// Create Spring context.
- AbstractBeanFactory fac = new XmlBeanFactory(
+ DefaultListableBeanFactory fac = new DefaultListableBeanFactory();
Review Comment:
check it plz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
